-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable ECE for non shipping products if Tax is calculated on billing address #9089
Disable ECE for non shipping products if Tax is calculated on billing address #9089
Conversation
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Size Change: +8 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
98997d6
to
58d2f22
Compare
58d2f22
to
8313819
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tests well ✅.
Left 2 questions in the comments.
includes/express-checkout/class-wc-payments-express-checkout-button-helper.php
Outdated
Show resolved
Hide resolved
45b4798
to
5b2b436
Compare
@ricardo do you mind approving the PR again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tests well!
Fixes #9080
Changes proposed in this Pull Request
Disables the ECE element on the following scenarios:
This is to avoid charging the shopper a different amount than what was presented on the payment sheet. More on that here.
Testing instructions
Test product, cart and checkout pages
wp option update _wcpay_feature_stripe_ece 1
Test Pay for order page is unaffected
npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge